[ 
https://issues.apache.org/jira/browse/SLING-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286483#comment-14286483
 ] 

Justin Edelson commented on SLING-4340:
---------------------------------------

[~cziegeler] so to your mind, in the scenario I described, what should

{code}
resourceResolver.getResource("/mnt/override/apps/a/1/a").getResourceType()
{code}
return?

With the change in SLING-4247, it returns "nt:unstructured". This, IMHO, is not 
correct. I expect the return value is "foo/bar" and that's what the change in 
r1653604 accomplishes.

And to be clear, my change does not assume that the sling:resourceType proeprty 
is set. It does, however, assume that if the sling:resourceType property is in 
the merged value map, it should take precedence. I agree this isn't ideal, but 
right now there's no other way (at least no other way I can think of) to get 
the correct value and I think this is a reasonable compromise.

> SLING-4247 created odd side-effects
> -----------------------------------
>
>                 Key: SLING-4340
>                 URL: https://issues.apache.org/jira/browse/SLING-4340
>             Project: Sling
>          Issue Type: Bug
>            Reporter: Justin Edelson
>            Assignee: Justin Edelson
>             Fix For: Resource Merger 1.2.4
>
>
> The change made in SLING-4247 created an unfortunate side effect for this 
> scenario:
> /apps/a/1/a - nt:unstructured node, no sling:resourceType property
> /apps/a/2/a - sling:resourceType set to foo/bar
> /apps/a/1 has sling:resourceSuperType set to /apps/a/2
> Then
> resourceResolver.getResource("/mnt/override/apps/a/1/a").getResourceType() 
> will be nt:unstructured
> This strikes me as wrong. And in fact screws up what is for me the main usage 
> of this feature because it shouldn't be necessary to set the 
> sling:resourceType all the time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to