[
https://issues.apache.org/jira/browse/SLING-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324217#comment-14324217
]
ASF GitHub Bot commented on SLING-4428:
---------------------------------------
GitHub user vladbailescu opened a pull request:
https://github.com/apache/sling/pull/65
SLING-4428 - Sightly: scriptComment and styleComment contexts are not
doing anything
Added support for multiline comment validation in XSS API.
Added implementation and test.
Added styleComment context to Sightly.
Added proper validation for scriptComment and styleComment contexts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladbailescu/sling
SLING-4428-Sightly-scriptComment-styleComment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 3b08e403a684ee393ce0321e9e1fe918b9e397e5
Author: vladbailescu <baile...@adobe.com>
Date: 2015-02-17T14:12:52Z
SLING-4428 - Sightly: scriptComment and styleComment contexts are not doing
anything
Added support for multiline comment validation in XSS API.
Added implementation and test.
commit f3b88492ea32d97ca25b1547226e579b7072e564
Author: vladbailescu <baile...@adobe.com>
Date: 2015-02-17T14:13:54Z
SLING-4428 - Sightly: scriptComment and styleComment contexts are not doing
anything
Added styleComment context.
Added proper validation for scriptComment and styleComment contexts.
----
> Sightly: scriptComment and styleComment contexts are not doing anything
> -----------------------------------------------------------------------
>
> Key: SLING-4428
> URL: https://issues.apache.org/jira/browse/SLING-4428
> Project: Sling
> Issue Type: Bug
> Reporter: Vlad Bailescu
> Priority: Minor
> Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0
>
>
> The Sightly spec defines scriptComment context but in the current
> implementation it is not working as expected, as it's treated internally like
> a JS token. This needs to be fixed so that the comment context will work as
> expected.
> The spec will clarify usage of the scriptComment context (it will only be
> used for block comments, ie: /*...*/) and will also add styleComment (which
> will behave similarly):
> https://github.com/Adobe-Marketing-Cloud/sightly-spec/pull/12
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
