[
https://issues.apache.org/jira/browse/SLING-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485080#comment-14485080
]
Carsten Ziegeler commented on SLING-2523:
-----------------------------------------
I think there is still room for improvement, several of the original problems
reported in this issue are not resolved; and they still might cause trouble.
SLING-4564 only solves the "too many observation listeners" problems
> Improve the JCR Installer
> -------------------------
>
> Key: SLING-2523
> URL: https://issues.apache.org/jira/browse/SLING-2523
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: JCR Installer 3.1.4
> Reporter: Carsten Ziegeler
> Attachments: SLING-2523_1.patch, SLING-2523_2.patch
>
>
> The current implementation has some drawbacks:
> - it registers several observation listeners
> - to handle deletes it has to register even more listeners
> - observation events are just used as markers and there is a polling thread
> running continously to check for changed markers and then rescan a sub tree
> in the repository
> - changes are not reported to the OSGi installer in one method call
> I think we can simplify and improve the implementation by
> - just registering a single observation listener for root and then do simple
> path matching operations
> - use the observation events to detect what has changed
> - report the changes in a single method call
> In addition it would be nice if the jcr installer waits befire reporting
> changes from an observation event and looks if there is not another
> observation event coming in "right after". This could improve situations
> where changes are not done by a single save but by a serious of saves
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
