Hi Andy, On Tue, 2015-04-28 at 09:02 -0700, Andreas Schaefer Sr. wrote: > Hi > > Most of the backend code inside the tooling project (api, impl > -resources etc) do not depend on Eclipse with the sole exception of > impl-vlt which use the Eclipse Plugin class inside the Activator and > uses the Activator’s getLogger() to obtain the logger inside that > module. > > IntelliJ does not use an OSGi container and even though I could stub > the Eclipse Plugin class it does not seem right. > > Can we split that module into 2 parts where one only contains the > backend code and the second would contain the Eclipse Plugin service > code and configuration? > > The only sticky issue I see is the call inside classes like > VltRepository to obtain the Plugin Logger: > Activator.getDefault().getPluginLogger(). One solution would be to > create another class like PluginLoggerProvider that has a static > method like getInstance() which has a setter and getter method for > the Plugin Logger. > > Cheers - Andy
Yup, mostly likely we need an indirection for obtaining the PluginLogger. Can you file a JIRA issue for this? And just to be sure, from your point of view it's fine that the Activator exists, it's just the calls to Activator.getDefault() that are troublesome, right? Thanks, Robert
