[ 
https://issues.apache.org/jira/browse/SLING-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585493#comment-14585493
 ] 

Carsten Ziegeler edited comment on SLING-4804 at 6/15/15 6:44 AM:
------------------------------------------------------------------

[~tomek.rekawek] Please don't apply this patch as it does not handle encoding 
of the path correctly. getRequestURI and getRequestURL return the path encoded, 
therefore if your path contains encoded characters like unicode you will get 
them as %xyz. I just stumbled across this problem recently (and that's why I 
asked for a http test case in SLING-848 :) ).
So far, the only potential solution I found is to apply a similar decoding as 
Jetty (or other servlet containers) does, which is pretty heavy. 


was (Author: cziegeler):
[~tomek.rekawek] Please don't apply this patch as it does not handle encoding 
of the path correctly. getRequestURI and getRequestURL return the path encoded, 
therefore if your patch contains encoded characters like unicode you will get 
them as %xyz. I just stumbled across this problem recently (and that's why I 
asked for a http test case in SLING-848 :) ).
So far, the only potential solution I found is to apply a similar decoding as 
Jetty (or other servlet containers do), which is pretty heavy. 

> Semicolon parameters are not passed to the resource resolver
> ------------------------------------------------------------
>
>                 Key: SLING-4804
>                 URL: https://issues.apache.org/jira/browse/SLING-4804
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: Engine 2.4.2
>            Reporter: Tomek Rękawek
>            Assignee: Tomek Rękawek
>            Priority: Minor
>             Fix For: Engine 2.4.4
>
>         Attachments: SLING-4804.patch
>
>
> SLING-848 provided a way to pass semicolon-separated parameters to the 
> resource provider. However, such parameters are removed from the 
> {{HttpServletRequest#getPathInfo()}}, which is used in the 
> {{RequestData#initResource()}} method to resolve the resource from the URI. 
> As a result, resource resolver and resource provider don't see the semicolon 
> parameters and can't use them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to