[
https://issues.apache.org/jira/browse/SLING-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Shypila updated SLING-4541:
--------------------------------
Attachment: week-4_first_part.patch
Just have added new unit tests for methods(week-4_first_part.patch). I have a
question.
In almost all test cases I initialise {{contentCreator}} with a same set of
arguments:
{code}
contentCreator.init(U.createImportOptions(false, false, false, false, false),
new HashMap<String, ContentReader>(), null, null);
contentCreator.prepareParsing(parentNode, null);
{code}
However, there are some cases where I should initialise {{contentCreator}} with
another parameters. Is it ok, to move this {{contentCreator}} initialisation to
test's setup method? And if we need to initialise {{contentCreator}} with
another parameters, then we could just call these methods in a test's method
again, but with correct parameters.
> Provide an extensive test suite for the JCR content loader
> ----------------------------------------------------------
>
> Key: SLING-4541
> URL: https://issues.apache.org/jira/browse/SLING-4541
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR ContentLoader 2.1.10
> Reporter: Radu Cotescu
> Assignee: Petr Shypila
> Fix For: JCR ContentLoader 2.2.0
>
> Attachments: week-4_first_part.patch, week2-part1-pathentry.patch,
> week2-part2-defaultcontentcreator.patch,
> week2-part3-single-jcrmock-test.patch, week3.patch
>
>
> The JCR content loader is a sensible bundle. An extensive IT suite should be
> written to make sure that code changes don't affect core functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
