[ https://issues.apache.org/jira/browse/SLING-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958925#comment-14958925 ]
Robert Munteanu commented on SLING-5152: ---------------------------------------- I _think_ the PR is good. However it's a bit unclear to me what the difference between prop.isMultiple() and def.isMultiple() is. Can these two ever disagree? For instance a property that is multi-valued but actually has a single value. > JsonJcrNode and JsonItemWriter should use prop.isMultiple() instead of > def.isMultiple() > --------------------------------------------------------------------------------------- > > Key: SLING-5152 > URL: https://issues.apache.org/jira/browse/SLING-5152 > Project: Sling > Issue Type: Improvement > Components: Commons > Affects Versions: Commons JSON 2.0.12 > Reporter: Joel Richard > Priority: Minor > Labels: json, performance > > In Oak, node.getDefinition().isMultiple() is is around 35 times slower than > prop.isMultiple(). In addition to this, MockProperty.isMultiple has to be > implemented because otherwise the tests fail (for which I will open another > issue shortly). -- This message was sent by Atlassian JIRA (v6.3.4#6332)