[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066434#comment-15066434
 ] 

Bertrand Delacretaz commented on SLING-5379:
--------------------------------------------

Thanks for your patch! It looks good to me in terms of code but I think it 
would be useful to factor our the "create a new bundle file with modified 
attributes" code - if only to allow other launchers to do the same thing.

Could you move this and the corresponding tests to the bundles/commons/osgi 
module? 

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> ----------------------------------------------------------------------------------
>
>                 Key: SLING-5379
>                 URL: https://issues.apache.org/jira/browse/SLING-5379
>             Project: Sling
>          Issue Type: New Feature
>          Components: Maven Plugins and Archetypes
>            Reporter: David Bosschaert
>             Fix For: Slingstart Maven Plugin 1.3.8
>
>         Attachments: sling_5379.patch
>
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.3{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to