[
https://issues.apache.org/jira/browse/SLING-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140975#comment-15140975
]
Konrad Windszus edited comment on SLING-5468 at 2/10/16 3:22 PM:
-----------------------------------------------------------------
Thanks [~jsedding] for the review. Regarding your feedback.
{quote}
I noticed one occasion in the CommonMergedResourceProviderTest where it says
relativePath != "/". This is never false.
{quote}
That is a mistake in the code I am gonna fix. That basic picker should only
provide something directly on the mount point but not somewhere below! So the
check must rather be {{if (relativePath.isEmpty())}}. Thanks for spotting it.
{quote}
Maybe having three levels of overlayed resources in
CommonMergedResourceProviderTest would be good. Only two levels can easily work
while three may already fail. (Not claiming that it does fail! However, adding
the extra test coverage should be easy now).
{quote}
I agree but this is not strictly necessary for the change I introduced. We can
easily add that later, once this is committed.
was (Author: kwin):
Thanks [~jsedding] for the review. Regarding your feedback.
{quote}
I noticed one occasion in the CommonMergedResourceProviderTest where it says
relativePath != "/". This is never false.
{quote}
That is a mistake in the code I am gonna fix. That basic picker should only
provide something directly on the mount point but not somewhere below! So the
check must rather be {{if (relativePath.isEmpty())}}. Thanks for spotting it.
{quote}
{quote}
Maybe having three levels of overlayed resources in
CommonMergedResourceProviderTest would be good. Only two levels can easily work
while three may already fail. (Not claiming that it does fail! However, adding
the extra test coverage should be easy now).
{quote}
I agree but this is not strictly necessary for the change I introduced. We can
easily add that later, once this is committed.
> Resource Merger: Provide a way to completely replace the underlying resources
> -----------------------------------------------------------------------------
>
> Key: SLING-5468
> URL: https://issues.apache.org/jira/browse/SLING-5468
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Resource Merger 1.2.10
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: Resource Merger 1.3.2
>
> Attachments: SLING-5468-v1.patch
>
>
> Currently whenever the mount point of the {{MergingResourcePicker}}
> (/mnt/overlay) or {{OverridingResourcePicker}} (/mnt/override) is used, the
> merging always takes place. It is only possible to hide/modify individual
> resource/properties of the underlying resources but not to completely disable
> the inheritance (and by that replace the whole overriden/overlaid resource).
> A concrete usecase for that is in a CMS (e.g. AEM) where the dialog
> definitions are always loaded via /mnt/override/<resource type>. In that case
> it is not easily possible to completely replace the dialog of the resource
> super type (as only individual child resources or properties can be hidden
> but there is no special property to ignore the inherited resource
> alltogether).
> I propose the following:
> Add a new property {{sling:disregardInheritedResource=true}} in which case
> all the inherited resources would not be taken into account for merging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
