Robert Munteanu wrote > Hi, > > We have a patch contributed some time ago in SLING-3100 [1] which adds > a m2e configurator for the content-package packaging type. > > What this means is that when a Maven project which is of type 'content- > package' is imported into Eclipse it's automatically configured as a > Sling content project, which removes a lot of frustration when users > import a project and it simply does not work :-) > > My first reaction at that time was to put the patch on hold, since the > content-package packaging type is contributed by the > com.day.jcr.vault:content-package-maven-plugin, which is not open > source. > > Thinking about this two years later, I am not sure whether that was > justified, since (1) the patch does not link to any kind of code which > is not Apache-2.0 friendly, but just makes a metadata entry related to > that plugin. > > Also, (2) this would help a lot users that use the IDE tooling together > with the content-package-maven-plugin. > > Keeping (1) in mind, is it acceptable from a legal POV to include this > patch? > Yes, I think there is nothing wrong here from a legal POV. In addition, this patch helps a large part of the Sling community.
Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
