[
https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15165678#comment-15165678
]
Georg Henzler commented on SLING-3100:
--------------------------------------
Well, also for me two years have passed - digging in my memory... ;)
{{M2E_ACTIVE}}: I think that one is easy to keep and it is just useful in that
1 promille of the cases, where you run into strange issues and you want to
disable it (maybe incompatibility with some other facet).
{{M2E_NATURES}}: Can definitely be removed
{{M2E_JCR_ROOT_PATH}}: Inferring it from {{build/resources/resource/directory}}
sounds good, if there is more than one resource tag, the one containing the
string "/jcr_root" could be taken. More exotic setups probably shouldn't even
be supported...
{{M2E_USE_WTP_PROJECT_SETUP}} if I remember it correctly, it was javascript
validations that didn't work without this - but today (and from my gut feeling)
I would definitely try without WTP (and trigger other file type validations
explicitly)
{{M2E_JAVA_FACET_VERSION}} is inferred already in the code
({{JavaFacetUtil.getCompilerLevel(project)}}) and is there for overriding the
inferred value only (probably worthwhile to leave it in?)
{{M2E_WEB_FACET_VERSION}} Inferring would be nice here as well, allowing to
override gives flexibility if things go wrong.
So in general it sounds all good, great to see that we are making progress here!
> Provide a m2e project configurator for packaging "content-package"
> ------------------------------------------------------------------
>
> Key: SLING-3100
> URL: https://issues.apache.org/jira/browse/SLING-3100
> Project: Sling
> Issue Type: New Feature
> Components: IDE
> Affects Versions: Sling Eclipse IDE 1.0.0
> Reporter: Konrad Windszus
> Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.1.0
>
> Attachments: 0001-WIP-do-not-push.patch,
> SLING-3100-m2e-integration.patch
>
>
> To set up the appropriate project configuration just from the POM an
> according m2e project configurator is needed
> (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29)
> The m2e-war-plugin comes with a project configurator which works also for
> content-packages pretty well but it is currently hard to reuse for any other
> packaging than "war" (due to the delegate pattern being used internally,
> compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if
> the project is having the dynamic web project facet the following features in
> Eclipse are supported:
> - JSP include directives (considered for validation and supports ctrl+click
> to open linked file)
> - Tag Library Support (
> http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F
> )
> - probably other features as well.
> Apart from that a feature like overlays should be supported (
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often
> content-package projects are referencing JSPs from other projects, and the
> IDE needs to know those, to complete the validation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
