[
https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195099#comment-15195099
]
Konrad Windszus edited comment on SLING-5605 at 3/15/16 11:02 AM:
------------------------------------------------------------------
Ok, but if we change the implementation a lot of clients may break, if they
rely on the wrong behaviour (which was there right from the beginning). I would
therefore suggest to just adjust the javadoc and leave the implementation as
is. That is IMHO much less dangerous.
was (Author: kwin):
Ok, but if we change the implementation a lot of clients may break, if they
rely on the wrong behaviour (which was there right from the beginning). If
would therefore suggest to just adjust the javadoc and leave the implementation
as is. That is IMHO much less dangerous.
> Wrong null annotations on ServletResolver interface
> ---------------------------------------------------
>
> Key: SLING-5605
> URL: https://issues.apache.org/jira/browse/SLING-5605
> Project: Sling
> Issue Type: Bug
> Components: API
> Affects Versions: API 2.11.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: API 2.12.0
>
>
> Currently all methods being defined on {{org.apache.sling.api.servlets}} are
> carrying the {{@Nonnull}} annotation
> (https://github.com/apache/sling/blob/trunk/bundles/api/src/main/java/org/apache/sling/api/servlets/ServletResolver.java).
> According to the implementation this is wrong and all three may return
> {{null}} in case there was no appropriate servlet found.
> The javadoc as well as the null annotations should be adjusted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
