Thanks for the hint. Wasn’t aware that Git would not remove these files during a merge but now I know. A nice “git clean” worked wonders.
- Andy > On Mar 17, 2016, at 9:58 AM, Oliver Lietz <apa...@oliverlietz.de> wrote: > > On Thursday 17 March 2016 09:52:13 Andreas Schaefer Sr. wrote: >> Ok, took some time to reproduce but it fails in the "Apache Sling Testing >> Modules Reactor” module. >> >> [INFO] Rat check: Summary of files. Unapproved: 3 unknown: 3 generated: 0 >> approved: 1 license. >> >> Rat.txt: >> >> ******************************* >> >> Unapproved licenses: >> >> >> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling. >> Development/sling-git-fork/sling/testing/samples/failing-tests/org.apache.sl >> ing.testing.samples.failingtests.iml >> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling. >> Development/sling-git-fork/sling/testing/samples/integration-tests/org.apach >> e.sling.testing.samples.integrationtests.iml >> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling. >> Development/sling-git-fork/sling/testing/samples/sample-tests/org.apache.sli >> ng.testing.samples.sampletests.iml >> >> ******************************* >> >> This is done based on my forked project and I will run it on a latest Sling >> trunk but I think it should be the same. > > These modules got removed, see SLING-5611 for details. You have to clean up > your project. > > Regards, > O. > > https://issues.apache.org/jira/browse/SLING-5611 > <https://issues.apache.org/jira/browse/SLING-5611> > >> Cheers - Andy >> >>> On Mar 17, 2016, at 1:11 AM, Robert Munteanu <romb...@apache.org> wrote: >>> >>> On Wed, 2016-03-16 at 17:01 -0700, Andreas Schaefer Sr. wrote: >>>> There is another issue I encountered. The RAT plugin is complaining >>>> about IntelliJ Module files (*.iml) files. >>>> >>>> I did include the exclude for **/*.iml but that is only local. I will >>>> include the change to the Parent POM inside the latest project but >>>> there are other POM files that do not have the exclude. >>>> >>>> I discussed this with Robert a while ago but the current Sling will >>>> not build for anyone using IntelliJ to work with Sling. >>> >>> Where exactly does this fail? >>> >>> Thanks, >>> >>> Robert >>> >>>> Cheers - Andy >>>> >>>>> On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <schaef...@me.com >>>>> >>>>>> wrote: >>>>> Ok, that did the trick. >>>>> >>>>> If I get a setup working I will debug it as I had a similar issue >>>>> (JCR Calendar issues based on timezones) in the past. I also will >>>>> see if I can reproduce it consistently. >>>>> >>>>> But at least I am now good to test my merge for a pull request. >>>>> >>>>> Thanks - Andy >>>>> >>>>>> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bdelacretaz@ap >>>>>> ache.org> wrote: >>>>>> >>>>>> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <schaefera@ >>>>>> >>>>>> me.com> wrote: >>>>>>> ...This line is causing the failure: >>>>>>> Assert.assertEquals(expected.getTimeZone().getRawOffset(), >>>>>>> actual.getTimeZone().getRawOffset()); ... >>>>>> >>>>>> Makes sense, good catch! >>>>>> >>>>>> I have changed the Calendar comparison method in >>>>>> https://issues.apache.org/jira/browse/SLING-5612, does that fix >>>>>> your >>>>>> issue? >>>>>> >>>>>> Also, if you find a way to reproduce it on any system (with >>>>>> -Duser.timezone maybe?) please add that info there, I haven't >>>>>> been >>>>>> able to reproduce it myself. >>>>>> >>>>>> -Bertrand
