[
https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300791#comment-15300791
]
Oliver Lietz commented on SLING-5603:
-------------------------------------
To be honest, I don't think Konrad's move is that clever. And in general,
please give some time to answer.
Short answer: Deploy Commons Lang 3.4 to AEM 6.1 also.
Long answer: This upgrade is part of an attempt to clean up Sling's messy
dependency setting¹.
We have tests for our artifacts per module and in
{{org.apache.sling.launchpad.integration-tests}} and I prefer to test with
dependencies which are used in Launchpad (a well defined set), because there
might be subtle differences even between minor versions (and we can not test
with all API compatible versions). Commons Lang 3.4 was released a year ago and
several bugs were fixed.
If you can deploy a newer components/services bundle (whether HC Core or
Validation Core or FS ClassLoader) to AEM, you can easily deploy a newer
library bundle. Both 3.3.2 and 3.4 can be deployed to AEM at the same time as
they have versioned package exports and the size of Commons Lang 3.4 can't be a
problem when talking about AEM where lots of bundles are loaded and running
which are hardly ever used.
For a small device/system where memory matters and older versions should be
supported you can relax package imports. This can also be done for HC Core,
Validation Core and FS ClassLoader if you really want to support older library
versions (with a small risk of subtle differences).
1. For example, see SLING-5624 and SLING-5623 where an unusual dependency broke
Health Check Core when not using Felix HTTP Service.
> Upgrade Commons Lang to 3.4
> ---------------------------
>
> Key: SLING-5603
> URL: https://issues.apache.org/jira/browse/SLING-5603
> Project: Sling
> Issue Type: Task
> Components: Launchpad
> Reporter: Oliver Lietz
> Fix For: File System ClassLoader 1.0.4, Validation 1.0.0,
> Launchpad Builder 9, Health Check Core 1.2.6
>
> Attachments: commons-lang.java.txt, commons-lang.pom.txt
>
>
> use Commons Lang {{3.4}} and phase out older versions e.g. {{2.0}}, {{2.2}},
> {{2.4}}, {{2.5}}, {{2.6}}, {{3.0}}, {{3.0.1}}, {{3.3.2}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
