Hi Robert, Yeah, I kind of rushed into getting things done.
The gist is this: * we have some new API in org.apache.sling.scripting.sightly.compiler [3] that allows for compiling Sightly scripts and getting an Abstract Syntax Tree as a result * most of the API that was previously exported by org.apache.sling.scripting.sightly is now exported by org.apache.sling.scripting.sightly.compiler.java [4]; the package org.apache.sling.scripting.sightly.render [5] is now exported with version 2.0.0 because RenderContext has changed in a backwards incompatible way If [5] is going to affect anyone I guess we can provide them with a compatibility bundle, but I don't think that there were other Sightly implementers. Cheers, Radu [3] - https://github.com/apache/sling/tree/trunk/bundles/scripting/sightly/compiler/src/main/java/org/apache/sling/scripting/sightly/compiler [4] - https://github.com/apache/sling/tree/trunk/bundles/scripting/sightly/java-compiler/src/main/java/org/apache/sling/scripting/sightly [5] - https://github.com/apache/sling/tree/trunk/bundles/scripting/sightly/java-compiler/src/main/java/org/apache/sling/scripting/sightly/render On Fri, 17 Jun 2016 at 21:50 Robert Munteanu <[email protected]> wrote: > Hi Radu, > > On Wed, 2016-06-15 at 14:38 +0000, Radu Cotescu wrote: > > Hi, > > > > I've recently opened a pull request for SLING-5787 [0] in order to > > get a > > chance to discuss the API change from the topic before committing the > > code > > to trunk. > > The code changes have been comitted, so this only serves as a kind > request for future reviews: > > please separate style changes from functional changes > > Your pull request has an impressive change count : +8,009 −5,465 , but > I notice lots of style changes - javadoc formatting, diamond operator > for generics, license header tweaks - which make it hard to review the > core of the pull request. > > Thanks, > > Robert >
