[
https://issues.apache.org/jira/browse/SLING-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386219#comment-15386219
]
Stefan Seifert commented on SLING-5837:
---------------------------------------
looks good to me - cosmetic remarks:
# javadoc (2 places): "A glob pattern should start with the glob: prefix" =>
use "must" instead of "should"
# perhaps use Pattern.quote of the java API instead of the manual check for
quoting via isRegexMeta method. perhaps add some more test cases for more
complex patterns including special chars to check that the quoting is working
correctly.
> Allow ResourceChangeListeners to define glob patterns for resource matching
> ---------------------------------------------------------------------------
>
> Key: SLING-5837
> URL: https://issues.apache.org/jira/browse/SLING-5837
> Project: Sling
> Issue Type: Improvement
> Components: API
> Affects Versions: API 2.12.0
> Reporter: Radu Cotescu
> Assignee: Radu Cotescu
> Fix For: API 2.14.0
>
> Attachments: SLING-5837.patch
>
>
> While the previous way to interact with Resource change events through
> registering {{EventHandler}} sevices allowed defining glob patterns for
> matching the watched paths, the current state of the
> {{org.apache.sling.api.resource.observation.ResourceChangeListener}} only
> allows subscribing to events for concrete paths.
> In order to allow for the same filtering flexibility,
> {{ResourceChangeListener}} should also accept glob patterns for its
> {{resource.paths}} configuration property.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
