Hi Radu, I am no longer convinced this is a good idea: http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05577.html <http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05577.html>. Therefore I don't think it is worth the effort. Also I agree that dealing with default values is much harder then. Sorry for the noise, Konrad
> On 27 Sep 2016, at 18:06, Radu Cotescu <[email protected]> wrote: > > Hi Konrad, > > We could attempt to integrate FileSet into the HTL's plugin configuration, > but what I don't like is that you're forced to specify a directory no > matter what (or at least that's what I understand from the documentation). > Could you send a patch? Then we could work together on this. > > Thanks, > Radu > > On Mon, 26 Sep 2016 at 15:21 Konrad Windszus <[email protected]> > wrote: > >> Currently the goal "validate" of the htl-maven-plugin takes three >> different parameters >> 1. sourceDirectory >> 2. includes >> 3. excludes >> >> That kind of triplet is already provided by the FileSet class ( >> http://maven.apache.org/shared/file-management/examples/mojo.html and >> https://maven.apache.org/shared/file-management/fileset.html). >> >> Quite some Maven Plugins use a file set already (e.g. Assembly descriptor, >> at http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html or >> maven-clean-plugin, >> https://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html), >> therefore I personally prefer to see the well-known FileSet type in a Maven >> Site documentation rather than 3 different parameters, where I need to >> figure out what kind of globbing is exactly supported. >> >> Since we had a 1.0.0 release already what do you think about deprecating >> the three previously mentioned parameters and instead just introduce a >> Collection of FileSets? >> That way you may provide multiple directories to be parsed and hopefully >> more people will understand, how to use that properly. >> >> Although not all properties from the FileSet are relevant to the >> htl-maven-plugin and although the BuildContext.newScanner does not directly >> take a FileSet as a parameter ( >> https://github.com/sonatype/sisu-build-api/blob/master/src/main/java/org/sonatype/plexus/build/incremental/BuildContext.java#L108) >> I would still think that using the FileSet would make things clearer. >> >> WDYT? >> Thanks for your input, >> Konrad
