[ 
https://issues.apache.org/jira/browse/SLING-6068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551893#comment-15551893
 ] 

ASF GitHub Bot commented on SLING-6068:
---------------------------------------

GitHub user kwin opened a pull request:

    https://github.com/apache/sling/pull/176

    SLING-6068 allow to build and start a quickstart even for non

    "slingstart" packaging projects

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kwin/sling 
SLING-6068-build-quickstart-from-model-for-ITs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit 85b8a1d993bdf75531c8b4b9d806790beff1101c
Author: Konrad Windszus <[email protected]>
Date:   2016-10-06T13:11:54Z

    SLING-6068 allow to build and start a quickstart even for non
    "slingstart" packaging projects

----


> slingstart-maven-plugin: Allow to start a quickstart JAR based on a 
> provisioning model even for non "slingstart" packagings
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-6068
>                 URL: https://issues.apache.org/jira/browse/SLING-6068
>             Project: Sling
>          Issue Type: Improvement
>          Components: Maven Plugins and Archetypes
>    Affects Versions: Slingstart Maven Plugin 1.4.4
>            Reporter: Konrad Windszus
>
> Currently the {{slingstart-maven-plugin}} can only start a server based on 
> textual model definitions in case the maven module is of packaging 
> "slingstart" 
> (https://sling.apache.org/documentation/development/slingstart.html#starting-a-server).
>  
> For ITs it is often beneficial to have them in the same module as the tested 
> classes itself (which in most cases have packaging {{bundle}}). Therefore it 
> would be nice, if even for other packaging values all model definitions below 
> {{src/main/provisioning}} would be considered during the goal {{start}} 
> (which must first build the quickstart.jar out of the models and then start 
> it).
> Compare also with the readme in 
> https://github.com/apache/sling/blob/trunk/testing/samples/bundle-with-it/pom.xml#L196.
>  This would be especially helpful for ITs leveraging the {{TeleporterRule}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to