[
https://issues.apache.org/jira/browse/SLING-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603702#comment-15603702
]
Alexander Klimetschek edited comment on SLING-5277 at 10/25/16 12:53 AM:
-------------------------------------------------------------------------
Attached new patch [^SLING-5277-new.patch] which solves the above discussed
issue.
The patch is against revision 1730513 though, right after the
org.apache.sling.servlets.resolver 2.4.2 release, as afterwards a lot of sling
changes happened that requires many bundles to update (which I couldn't easily
do in my environment).
I haven't got good test numbers yet (only tested this issue together with other
changes), but independent tests would be great! /cc [~joerghoh]
was (Author: alexander.klimetschek):
Attached new patch [^SLING-5277-new.patch] which solves the above discussed
issue.
I haven't got good test numbers yet (only tested this issue together with other
changes), but independent tests would be great! /cc [~joerghoh]
> Performance: per thread script resolver (admin session) is always created
> even if cache is hit
> ----------------------------------------------------------------------------------------------
>
> Key: SLING-5277
> URL: https://issues.apache.org/jira/browse/SLING-5277
> Project: Sling
> Issue Type: Bug
> Components: Servlets
> Reporter: Alexander Klimetschek
> Attachments: SLING-5277-new.patch, SLING-5277.patch
>
>
> Since SLING-3441, for every request, a new admin / privileged session is
> [created in the
> SlingServletResolver|https://github.com/apache/sling/blob/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java#L532].
> It is created before the script/servlet cache is checked, so in most cases
> when the cache is hit it is never used, but the cost of creating an extra
> session (which can vary, especially with concurrent traffic) is incurred.
> The per thread script resolver can be created lazily instead of directly in
> the event to avoid this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
