Hey Carsten, Okey, I will look for contributing a patch :).
The reason I would personally add the pom.xml is so that you know how the archive was actually built, what dependencies it has, a name and description, maybe some link to documentation to a github from the scm tags. Greets, Roy > On 12 Dec 2016, at 09:25, Carsten Ziegeler <[email protected]> wrote: > > Roy Teeuwen wrote >> Hey Carsten, >> >> I had a look at the slingshot example that you set up with this. I see that >> a file slingstart.mar gets created, containing all the jars and model files >> that are necessary. >> >> Is there a reason that the name is always slingstart.mar, and not for >> example artifactId-version.mar? Or that it is configureable? >> If one would like to use multiple generated mar files and throw them in an >> install folder, this would get cumbersome seeing as all the files are called >> slingstart.mar > > This is just the name of the file in the target folder, in the maven > repo it has the correct name. But I see your point and we can easily > change this in the plugin. Do you want to contribute a patch? > >> >> I also noticed you don't include the actual maven pom inside the mar file, >> maybe this would be a good addition, seeing as I think standard all archives >> built with maven contain the pom that it is built with? > > Not sure what this could be good for? > > Regards > Carsten > >> >> Greetings, >> Roy >> >>> On 12 Nov 2016, at 18:19, Carsten Ziegeler <[email protected]> wrote: >>> >>> Hi, >>> >>> I've just added support to create an archive (jar file) with a >>> provisioning model and all the contained artifacts. Initially I thought >>> that we don't need this..but... >>> >>> I used the slingshot sample project as a driver for this as that project >>> consists of a bundle and a provisioning model for the repoinit part. And >>> we need this Sling specific support for repoinit. >>> >>> If you're configuring the slingstart maven plugin with the additional >>> attach-modelarchive goal, it creates such an archive as an additional >>> artifact of the project. >>> >>> I've also added a new module to the installer family which can pick up >>> such an archive and install the contained features, including repoinit, >>> configurations and all artifacts. This module installer is simply >>> forwarding the configurations and artifacts to the OSGi installer which >>> then takes care of the installation logic. >>> >>> This is a first approach which works, but I'm pretty sure it can be >>> improved here and there. >>> >>> With this we have everything in place (except for releasing the relevant >>> modules) to include slingshot in Sling 9. >>> >>> Regards >>> Carsten >>> -- >>> Carsten Ziegeler >>> Adobe Research Switzerland >>> [email protected] >> >> > > > > > -- > Carsten Ziegeler > Adobe Research Switzerland > [email protected] <mailto:[email protected]>
