On Wednesday 21 December 2016 17:02:49 Robert Munteanu wrote:
> On Wed, 2016-12-21 at 15:46 +0100, Oliver Lietz wrote:
> > On Monday 19 December 2016 11:33:54 Robert Munteanu wrote:
> > > Hi Olli,
> > 
> > Hi Robert,
> > 
> > > I guess you just discovered why we don't allow SNAPSHOT
> > > dependencies to
> > > external projects in trunk :-)
> > 
> > no, I'm aware that external SNAPSHOTs are not accessible in our
> > default build 
> > setup and disabled all Karaf build jobs _before_ using them.
> 
> Right, that does indeed save us the trouble of being flooded by
> notifications, which is appreciated.
> 
> > > Rather than remove the jobs, please work on a branch if you have
> > > work
> > > that requires SNAPSHOT dependencies. That's what we did for the IDE
> > > tooling until FileVault was released, for instance.
> > > 
> > > This way both the Jenkins jobs and other contributors/committers
> > > besides yourself can build the Karaf integration.
> > 
> > Further development is blocked as Sling requires R6 Http features
> > which are 
> > not available with Karaf 4.0. I have to use Karaf 4.1-SNAPSHOT and
> > Pax Web 
> > 6.0-SNAPSHOT, please see SLING-6411.
> 
> Ack
> 
> > We hadn't a release yet and there are no other Sling developers
> > moving 
> > Sling/Karaf forward – so I don't see a problem in disabling the build
> > jobs.
> 
> Ack. My point was not about the build jobs, it's about keeping trunk in
> a buildable state at all times.
> 
> I understand your argument about no release and no other contributors.
> However, we don't know who is trying to build the SVN repository and
> who is interested in the Karaf integration. They might try building it
> only to have it fail due to missing dependencies.
> 
> I like simple rules :-) one of those is having trunk always build.
> 
> What would be the disadvantage of working with SNAPSHOTs in branches
> and merging back to trunk once we have releases of the respective
> projects?

Well, the extra work of branching and merging in SVN. It's my spare time I 
spend on Sling.

The Sling/Karaf build is frequently broken by other developers who do not care 
about those modules. Especially the org.apache.sling.karaf-launchpad-oak-tar-
integration-tests module where I have to use snapshots of test bundles.

I'm not happy with the current situation either but trying to get it fixed 
(see related issues in upstream projects also: Karaf, Pax Web, Pax Exam).

The same time I switched to Karaf snapshots the README was updated and every 
move is documented in JIRA. So it should be very clear that it is work in 
progress.

Regards,
O.

> Thanks,
> 
> Robert
> 
> > Thanks,
> > O.
> > 
> > > Thanks,
> > > 
> > > Robert
> > > 
> > > On Sun, 2016-12-18 at 10:15 +0000, o...@apache.org wrote:
> > > > Author: olli
> > > > Date: Sun Dec 18 10:15:02 2016
> > > > New Revision: 1774871
> > > > 
> > > > URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
> > > > Log:
> > > > SLING-6411 Upgrade Karaf to 4.1
> > > > 
> > > > disable Jenkins build jobs due to use of external snapshots
> > > > 
> > > > Modified:
> > > >     sling/trunk/tooling/jenkins/create_jobs.groovy
> > > > 
> > > > Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
> > > > URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/cre
> > > > ate_
> > > > jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
> > > > =================================================================
> > > > ====
> > > > =========
> > > > --- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
> > > > +++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18
> > > > 10:15:02 2016
> > > > @@ -32,7 +32,7 @@ def modules = [
> > > >      ],
> > > >      [
> > > >          location: 'bundles/commons/log-webconsole'
> > > > -    ],    
> > > > +    ],
> > > >      [
> > > >          location: 'bundles/commons/logservice'
> > > >      ],
> > > > @@ -593,24 +593,24 @@ def modules = [
> > > >      [
> > > >          location: "installer/providers/file"
> > > >      ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-distribution'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-features'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-integration-
> > > > tests'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > > > tar-
> > > > integration-tests'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-repoinit'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-configs'
> > > > -    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-distribution'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-features'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-integration-
> > > > tests'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > > > tar-
> > > > integration-tests'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-repoinit'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-configs'
> > > > +//    ],
> > > >      [
> > > >          location: 'launchpad/api',
> > > >          jdks: ["1.8"]
> > > > @@ -915,7 +915,7 @@ for more details</p>''')
> > > >              // job is triggered first and we may end up with a
> > > >              // mix of Java 7 and Java 8 artifacts for projects
> > > > which
> > > >              // use these 2 versions
> > > > -            def extraGoalsParams = module.extraGoalsParams ?:
> > > > "" 
> > > > +            def extraGoalsParams = module.extraGoalsParams ?: ""
> > > >              goals( (deploy ? "-U clean deploy" : "-U clean
> > > > verify")
> > > > + " " + extraGoalsParams)
> > > >  
> > > >              publishers {


Reply via email to