> On 9 Jan 2017, at 06:00, Robert Munteanu <romb...@apache.org> wrote: > > Hi Konrad, > > On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote: >> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=434033. >> Any suggestions which annotation types to use in the Eclipse IDE for >> null checks? >> Or would it be fine to build the Sling IDE with target 1.8? > > I am not opposed to building the IDE tooling with target 1.8 . First > though, there is a workaround noted in the Eclipse bug: > > please make sure that an in projects below 1.8 you reference version > [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!) > > Would that work for our scenario?
I have not tested that, but I just checked that indeed at least Eclipse Neon ships with two different versions of that bundle 1.1.100 and 2.1.0 but I am not sure about older and newer versions of Eclipse. I would rather instead upgrade to Java 8, since with Neon Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Installation). WDYT? > > Robert > >> Konrad >> >>> On 29 Dec 2016, at 18:01, Apache Jenkins Server <jenk...@builds.apa >>> che.org> wrote: >>> >>> See <https://builds.apache.org/job/sling-ide/88/changes> >>> >>> Changes: >>> >>> [kwin] SLING-6344 disable syncing if no filter.xml can be found >>> >>> simplify FilterLocator service >>> >>> ------------------------------------------ >>> [...truncated 899 lines...] >>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ >>> reactor --- >>> [INFO] >>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach- >>> descriptor) @ reactor --- >>> [INFO] >>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files >>> (default) @ reactor --- >>> [INFO] >>> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor --- >>> [INFO] 72 implicit excludes (use -debug for more details). >>> [INFO] Exclude: derby.log >>> [INFO] Exclude: .gitignore >>> [INFO] Exclude: README.md >>> [INFO] Exclude: *.launch >>> [INFO] Exclude: build.properties >>> [INFO] Exclude: .options >>> [INFO] Exclude: META-INF/MANIFEST.MF >>> [INFO] Exclude: **/*.binary >>> [INFO] Exclude: eclipse-test/** >>> [INFO] Exclude: source-bundle/target/** >>> [INFO] Exclude: .Xauthority-* >>> [INFO] 6 resources included (use -debug for more details) >>> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: >>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansion >>> Limit' is not recognized. >>> Compiler warnings: >>> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http:// >>> javax.xml.XMLConstants/property/accessExternalDTD' is not >>> recognized.' >>> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://java >>> x.xml.XMLConstants/feature/secure-processing' is not recognized. >>> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://jav >>> ax.xml.XMLConstants/property/accessExternalDTD' is not recognized. >>> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www >>> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not >>> recognized. >>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 >>> generated: 0 approved: 5 licence. >>> [JENKINS] Archiving disabled >>> [INFO] >>> >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] Building Sling IDE Tools: Target definition 1.1.1-SNAPSHOT >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] >>> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ >>> org.apache.sling.ide.target-definition --- >>> [INFO] >>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ >>> org.apache.sling.ide.target-definition --- >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:package-target-definition >>> (default-package-target-definition) @ org.apache.sling.ide.target- >>> definition --- >>> [INFO] >>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach- >>> descriptor) @ org.apache.sling.ide.target-definition --- >>> [INFO] >>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files >>> (default) @ org.apache.sling.ide.target-definition --- >>> [INFO] >>> [INFO] --- apache-rat-plugin:0.10:check (default) @ >>> org.apache.sling.ide.target-definition --- >>> [INFO] 51 implicit excludes (use -debug for more details). >>> [INFO] Exclude: derby.log >>> [INFO] Exclude: .gitignore >>> [INFO] Exclude: README.md >>> [INFO] Exclude: *.launch >>> [INFO] Exclude: build.properties >>> [INFO] Exclude: .options >>> [INFO] Exclude: META-INF/MANIFEST.MF >>> [INFO] Exclude: **/*.binary >>> [INFO] Exclude: eclipse-test/** >>> [INFO] Exclude: source-bundle/target/** >>> [INFO] Exclude: .Xauthority-* >>> [INFO] 3 resources included (use -debug for more details) >>> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: >>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansion >>> Limit' is not recognized. >>> Compiler warnings: >>> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http:// >>> javax.xml.XMLConstants/property/accessExternalDTD' is not >>> recognized.' >>> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://java >>> x.xml.XMLConstants/feature/secure-processing' is not recognized. >>> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://jav >>> ax.xml.XMLConstants/property/accessExternalDTD' is not recognized. >>> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www >>> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not >>> recognized. >>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 >>> generated: 0 approved: 3 licence. >>> [JENKINS] Archiving disabled >>> [INFO] >>> >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] Building Sling IDE Tools: FileVault wrapper 1.1.1-SNAPSHOT >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] >>> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ >>> org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:build-qualifier (default- >>> build-qualifier) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] The project's OSGi version is 1.1.1.201612291701 >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:validate-id (default- >>> validate-id) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:validate-version (default- >>> validate-version) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- maven-dependency-plugin:2.8:copy (default) @ >>> org.apache.sling.ide.vlt-wrapper --- >>> [INFO] Configured Artifact: javax.jcr:jcr:2.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit- >>> webdav:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit-spi- >>> commons:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit-jcr- >>> commons:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit- >>> jcr2spi:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit-jcr- >>> client:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit- >>> spi:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit:jackrabbit- >>> spi2dav:2.4.0:jar >>> [INFO] Configured Artifact: org.apache.jackrabbit.vault:vault- >>> davex:3.0.0:jar >>> [INFO] Configured Artifact: >>> org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:3.0.0:jar >>> [INFO] Copying jcr-2.0.jar to <https://builds.apache.org/job/sling- >>> ide/ws/vlt-wrapper/lib/jcr-2.0.jar> >>> [INFO] Copying jackrabbit-webdav-2.4.0.jar to <https://builds.apach >>> e.org/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-webdav-2.4.0.jar> >>> [INFO] Copying jackrabbit-spi-commons-2.4.0.jar to <https://builds. >>> apache.org/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-spi-commons- >>> 2.4.0.jar> >>> [INFO] Copying jackrabbit-jcr-commons-2.4.0.jar to <https://builds. >>> apache.org/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-jcr-commons- >>> 2.4.0.jar> >>> [INFO] Copying jackrabbit-jcr2spi-2.4.0.jar to <https://builds.apac >>> he.org/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-jcr2spi- >>> 2.4.0.jar> >>> [INFO] Copying jackrabbit-jcr-client-2.4.0.jar to <https://builds.a >>> pache.org/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-jcr-client- >>> 2.4.0.jar> >>> [INFO] Copying jackrabbit-spi-2.4.0.jar to <https://builds.apache.o >>> rg/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-spi-2.4.0.jar> >>> [INFO] Copying jackrabbit-spi2dav-2.4.0.jar to <https://builds.apac >>> he.org/job/sling-ide/ws/vlt-wrapper/lib/jackrabbit-spi2dav- >>> 2.4.0.jar> >>> [INFO] Copying vault-davex-3.0.0.jar to <https://builds.apache.org/ >>> job/sling-ide/ws/vlt-wrapper/lib/vault-davex-3.0.0.jar> >>> [INFO] Copying org.apache.jackrabbit.vault-3.0.0.jar to <https://bu >>> ilds.apache.org/job/sling-ide/ws/vlt- >>> wrapper/lib/org.apache.jackrabbit.vault-3.0.0.jar> >>> [INFO] >>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ >>> org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) >>> @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>> [INFO] Copying 2 resources >>> [INFO] Copying 3 resources >>> [INFO] >>> [INFO] --- tycho-compiler-plugin:0.22.0:compile (default-compile) @ >>> org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- maven-resources-plugin:2.6:testResources (default- >>> testResources) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>> [INFO] skip non existing resourceDirectory <https://builds.apache.o >>> rg/job/sling-ide/ws/vlt-wrapper/src/test/resources> >>> [INFO] Copying 3 resources >>> [INFO] >>> [INFO] --- target-platform-configuration:0.22.0:target-platform >>> (default-target-platform) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:package-plugin (default- >>> package-plugin) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] Building jar: <https://builds.apache.org/job/sling-ide/ws/vl >>> t-wrapper/target/org.apache.sling.ide.vlt-wrapper-1.1.1- >>> SNAPSHOT.jar> >>> [INFO] >>> [INFO] --- tycho-p2-plugin:0.22.0:p2-metadata-default (default-p2- >>> metadata-default) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach- >>> descriptor) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] >>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files >>> (default) @ org.apache.sling.ide.vlt-wrapper --- >>> [INFO] Checking legal files in: org.apache.sling.ide.vlt-wrapper- >>> 1.1.1-SNAPSHOT.jar >>> [INFO] >>> [INFO] --- apache-rat-plugin:0.10:check (default) @ >>> org.apache.sling.ide.vlt-wrapper --- >>> [INFO] 51 implicit excludes (use -debug for more details). >>> [INFO] Exclude: derby.log >>> [INFO] Exclude: .gitignore >>> [INFO] Exclude: README.md >>> [INFO] Exclude: *.launch >>> [INFO] Exclude: build.properties >>> [INFO] Exclude: .options >>> [INFO] Exclude: META-INF/MANIFEST.MF >>> [INFO] Exclude: **/*.binary >>> [INFO] Exclude: eclipse-test/** >>> [INFO] Exclude: source-bundle/target/** >>> [INFO] Exclude: .Xauthority-* >>> [INFO] 13 resources included (use -debug for more details) >>> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: >>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansion >>> Limit' is not recognized. >>> Compiler warnings: >>> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http:// >>> javax.xml.XMLConstants/property/accessExternalDTD' is not >>> recognized.' >>> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://java >>> x.xml.XMLConstants/feature/secure-processing' is not recognized. >>> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://jav >>> ax.xml.XMLConstants/property/accessExternalDTD' is not recognized. >>> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www >>> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not >>> recognized. >>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 >>> generated: 0 approved: 1 licence. >>> [JENKINS] Archiving disabled >>> [INFO] >>> >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] Building Sling IDE Tools: API 1.1.1-SNAPSHOT >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] >>> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ >>> org.apache.sling.ide.api --- >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:build-qualifier (default- >>> build-qualifier) @ org.apache.sling.ide.api --- >>> [INFO] The project's OSGi version is 1.1.1.201612291701 >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:validate-id (default- >>> validate-id) @ org.apache.sling.ide.api --- >>> [INFO] >>> [INFO] --- tycho-packaging-plugin:0.22.0:validate-version (default- >>> validate-version) @ org.apache.sling.ide.api --- >>> [INFO] >>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ >>> org.apache.sling.ide.api --- >>> [INFO] >>> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) >>> @ org.apache.sling.ide.api --- >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>> [INFO] Copying 4 resources >>> [INFO] Copying 3 resources >>> [INFO] >>> [INFO] --- tycho-compiler-plugin:0.22.0:compile (default-compile) @ >>> org.apache.sling.ide.api --- >>> [INFO] Compiling 40 source files to <https://builds.apache.org/job/ >>> sling-ide/ws/api/target/classes> >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled >>> [JENKINS] Archiving disabled[INFO] -------------------------------- >>> ---------------------------------------- >>> [INFO] Reactor Summary: >>> [INFO] >>> [INFO] Sling IDE Tools: Reactor ........................... SUCCESS >>> [ 3.101 s] >>> [INFO] Sling IDE Tools: Target definition ................. SUCCESS >>> [ 0.767 s] >>> [INFO] Sling IDE Tools: FileVault wrapper ................. SUCCESS >>> [ 2.792 s] >>> [INFO] Sling IDE Tools: API ............................... FAILURE >>> [ 1.861 s] >>> [INFO] Sling IDE Tools: API Tests ......................... SKIPPED >>> [INFO] Sling IDE Tools: Embedded Artifacts ................ SKIPPED >>> [INFO] Sling IDE Tools: Eclipse Core ...................... SKIPPED >>> [INFO] Sling IDE Tools: Resource-based Implementation ..... SKIPPED >>> [INFO] Sling IDE Tools: Resource-based Implementation Tests SKIPPED >>> [INFO] Sling IDE Tools: FileVault implementation .......... SKIPPED >>> [INFO] Sling IDE Tools: FileVault Implementation Tests .... SKIPPED >>> [INFO] Sling IDE Tools: Eclipse UI ........................ SKIPPED >>> [INFO] Sling IDE Tools: Eclipse Feature ................... SKIPPED >>> [INFO] Sling IDE Tools: Eclipse M2Eclipse-based Core ...... SKIPPED >>> [INFO] Sling IDE Tools: Eclipse M2Eclipse-based UI ........ SKIPPED >>> [INFO] Sling IDE Tools: Eclipse Sightly Core .............. SKIPPED >>> [INFO] Sling IDE Tools: Eclipse Sightly UI ................ SKIPPED >>> [INFO] Sling IDE Tools: Sightly Feature ................... SKIPPED >>> [INFO] Sling IDE Tools: Eclipse Tests ..................... SKIPPED >>> [INFO] Sling IDE Tools: Eclipse M2Eclipse-based Tests ..... SKIPPED >>> [INFO] Sling IDE Tools: M2Eclipse-based Feature ........... SKIPPED >>> [INFO] Sling IDE Tools: Update Site ....................... SKIPPED >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] BUILD FAILURE >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [INFO] Total time: 50.548 s >>> [INFO] Finished at: 2016-12-29T17:01:55+00:00 >>> >>> [INFO] Final Memory: 148M/871M >>> [INFO] ------------------------------------------------------------ >>> ------------ >>> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler- >>> plugin:0.22.0:compile (default-compile) on project >>> org.apache.sling.ide.api: Compilation failure: Compilation failure: >>> [ERROR] <https://builds.apache.org/job/sling-ide/ws/api/src/org/apa >>> che/sling/ide/filter/FilterLocator.java>:[33] >>> [ERROR] @NonNull Filter loadFilter(@NonNull IProject project) >>> throws IOException, IllegalStateException; >>> [ERROR] ^^^^^^^^ >>> [ERROR] Syntax error, type annotations are available only when >>> source level is at least 1.8 >>> [ERROR] <https://builds.apache.org/job/sling-ide/ws/api/src/org/apa >>> che/sling/ide/filter/FilterLocator.java>:[33] >>> [ERROR] @NonNull Filter loadFilter(@NonNull IProject project) >>> throws IOException, IllegalStateException; >>> [ERROR] ^^^^^^^^ >>> [ERROR] Syntax error, type annotations are available only when >>> source level is at least 1.8 >>> [ERROR] 2 problems (2 errors) >>> [ERROR] -> [Help 1] >>> [ERROR] >>> [ERROR] To see the full stack trace of the errors, re-run Maven >>> with the -e switch. >>> [ERROR] Re-run Maven using the -X switch to enable full debug >>> logging. >>> [ERROR] >>> [ERROR] For more information about the errors and possible >>> solutions, please read the following articles: >>> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/M >>> ojoFailureException >>> [ERROR] >>> [ERROR] After correcting the problems, you can resume the build >>> with the command >>> [ERROR] mvn <goals> -rf :org.apache.sling.ide.api >>> Xvfb stopping >>> channel stopped >> >> >
