Great! I'll cut the release today and btw. good catch wrt the retry issue- without your insistence I wouldn't have spotted that the test didn't test the right thing and subsequently, not found the remaining bugs in the patch!
regards, Karl On Thu, Feb 16, 2017 at 11:47 AM, Konrad Windszus <konra...@gmx.de> wrote: > I just committed the fix for SLING-6392. Can you please set the Fix Version > of SLING-5457 (I assume to Installer Core 3.8.4)? > Nothing blocking a release now from my side. > Thanks for taking care, > Konrad > >> On 16 Feb 2017, at 00:31, Karl Pauls <karlpa...@gmail.com> wrote: >> >> Hi Konrad, >> >> SLING-6392 looks good. If you commit it (and assuming you agree with >> SLING-5457 for now) I would go ahead and cut a release. >> >> regards, >> >> Karl >> >> On Wed, Feb 15, 2017 at 3:25 PM, Karl Pauls <karlpa...@gmail.com> wrote: >>> I'll have a look. >>> >>> regards, >>> >>> Karl >>> >>> On Wed, Feb 15, 2017 at 2:45 PM, Konrad Windszus <konra...@gmx.de> wrote: >>>> Hi, >>>> since obviously the next release of the OSGi Installer is imminent >>>> (https://issues.apache.org/jira/browse/SLING-5457?focusedCommentId=15867820&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15867820) >>>> could someone please look at the proposed patch in >>>> https://issues.apache.org/jira/browse/SLING-6392 and include it if the >>>> patch is sufficient? >>>> It would be IMHO very nice to have that flaw patched in the next version. >>>> Thanks, >>>> Konrad >>> >>> >>> >>> -- >>> Karl Pauls >>> karlpa...@gmail.com >> >> >> >> -- >> Karl Pauls >> karlpa...@gmail.com > -- Karl Pauls karlpa...@gmail.com
