[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897451#comment-15897451
]
Julian Sedding commented on SLING-6609:
---------------------------------------
bq. Maybe you could add the annotation plus add an implementation note, that
implementations should treat being called with {{defaultValue==null}}
equivalent to {{get(String)}} and thus to check for {{null}}.
That sounds reasonable and strikes a nice balance between backwards
compatibility and clarification/evolution of the API contract.
bq. Of course this is debatable and in hind sight we should have properly
define the API such that defaultValue must not be null (with the respective
runtime check on implementations). But we are where we are.
Indeed. Hind sight is a luxury we rarely have in the beginning ;)
> Fix JSR305 annotations for ValueMap.get
> ---------------------------------------
>
> Key: SLING-6609
> URL: https://issues.apache.org/jira/browse/SLING-6609
> Project: Sling
> Issue Type: Bug
> Components: API
> Affects Versions: API 2.16.2
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Fix For: API 2.16.4
>
>
> Currently {{<T> T get(@Nonnull String name, T defaultValue);}} does neither
> define a JSR 305 annotation for the return value nor for the 2nd parameter.
> It makes sense to define them both as {{@Nonnull}}, because if you intend to
> get {{null}} as return value you are supposed to take the other get method
> ({{@CheckForNull <T> T get(@Nonnull String name, @Nonnull Class<T> type)}})
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
