[ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937126#comment-15937126
 ] 

Karl Pauls commented on SLING-6679:
-----------------------------------

[~sseif...@pro-vision.de] I'm not sure I understand what you are talking about 
wrt exception: 

catch(Exception e) is going to catch RuntimeException as well as 
RuntimeException derived Exceptions. So in that regard, 
javax.json.JsonException will be caught by the catch as is. However, I do agree 
that it is not equivalent to the previous catch(JSONException e) as it is 
broader. 

Are you saying we should just catch javax.json.JsonException to prevent masking 
other exceptions (if so, I can agree even so iirc, I did only do it in places 
where it seemed like there shouldn't be much other stuff being masked but 
better save than sorry)? 

> Replace usage of org.apache.sling.commons.json.*
> ------------------------------------------------
>
>                 Key: SLING-6679
>                 URL: https://issues.apache.org/jira/browse/SLING-6679
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to