[ 
https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064562#comment-16064562
 ] 

Robert Munteanu commented on SLING-6955:
----------------------------------------

The conversion looks good overall to me, no major issues found. Some minor 
things I noticed:

* http://localhost:8820/documentation/development/maven-launchpad-plugin.html 
has a {{translation_pending: true}} attribute included "as-is"
* http://localhost:8820/documentation/development/maventipsandtricks.html -  
the MAVEN_OPTS header looks weird
* 
http://localhost:8820/documentation/tutorials-how-tos/installing-and-upgrading-bundles.html
 has an {{Excerpt: ...}} attribute included "as-is" . Note also the {{:::html}} 
preamble for the markup, I never saw that one until now :-)

A random thought - is it possible (and easy) with JBake to simply redirect the 
{{[TOC]}} macro to generate nothing? It might make the transition smoother and 
the site would looks less broken

> Convert Sling website to JBake and gitpubsub
> --------------------------------------------
>
>                 Key: SLING-6955
>                 URL: https://issues.apache.org/jira/browse/SLING-6955
>             Project: Sling
>          Issue Type: Bug
>          Components: Site
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>
> I've started experimenting with JBake to generate the Sling website. If that 
> works well we might switch to that + gitpubsub to have a more flexible way to 
> generate the site.
> My current experiment is at https://github.com/bdelacretaz/sling-jbake, at 
> this point the site starts looking like the current one and many pages work 
> well. 
> Internal links will need to be converted, all *.md files need a more complete 
> "front matter" section, currently I have a stub for that, and I think images 
> need to move under the assets folder.
> To play with that, generate the site with the bake.sh script (setup 
> shamelessly copied from https://github.com/apache/incubator-tamaya-site)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to