[ 
https://issues.apache.org/jira/browse/SLING-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099775#comment-16099775
 ] 

Radu Cotescu commented on SLING-7000:
-------------------------------------

I still cannot apply your patch - with {{git apply}} I get:
{noformat}
error: git apply: bad git-diff - inconsistent old filename on line 803
{noformat}

which is again caused by 
{{src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/ModifiableRequestPathInfoTest.java}}.

With {{patch -p0}} in the {{bundles/scripting/sightly/engine}} folder I get:
{noformat}
can't find file to patch at input line 805
{noformat}

which refers to the same problematic move.

Please try to create a patch on top of a clean checkout / clone from {{trunk}} 
or send a GitHub PR.

> HTL: URIManipulatorFilterExtension destroys opaque URIs
> -------------------------------------------------------
>
>                 Key: SLING-7000
>                 URL: https://issues.apache.org/jira/browse/SLING-7000
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting Sightly Engine 1.0.0, Scripting HTL Engine 
> 1.0.34
>            Reporter: Konrad Windszus
>            Assignee: Radu Cotescu
>         Attachments: SLING-7000-v01-test.patch, SLING-7000-v1.patch, 
> SLING-7000-v2.patch
>
>
> When using the URI manipulator's extension option 
> (https://github.com/Adobe-Marketing-Cloud/htl-spec/blob/master/SPECIFICATION.md#125-uri-manipulation)
>  on a mailto link (or any other opaque URI) the value is completely messed up.
> {code:java}
> <a href="${'mailto:some.m...@apache.org' @ extension='html'}">
> {code}
> The {{URIManipulationFilterExtension}} returns 
> {code}
> mailto://null.html
> {code} 
> through its {{call(...)}} method with parameter {{arguments}} being set to 
> {code}
> [mailto:kon...@netcentric.biz, {extension=html}]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to