I cancel this vote due to the issue being found by Oli. I will respin the release as soon as https://issues.apache.org/jira/browse/SLING-7302 <https://issues.apache.org/jira/browse/SLING-7302> and https://issues.apache.org/jira/browse/SLING-7299 <https://issues.apache.org/jira/browse/SLING-7299> are resolved and integrated in a new slingstart-maven-plugin release. Sorry for this. Konrad
> On 10. Dec 2017, at 15:10, Konrad Windszus <konra...@gmx.de> wrote: > > > >> On 10. Dec 2017, at 14:06, Oliver Lietz <apa...@oliverlietz.de> wrote: >> >> On Saturday 09 December 2017 17:39:23 Konrad Windszus wrote: >>> Hi, >>> >>> We solved 3 issues in this release: >>> https://issues.apache.org/jira/projects/SLING/versions/12340348 >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachesling-1832/ >>> >>> You can use this UNIX script to download the release and verify the >>> signatures: >>> https://github.com/apache/sling-tooling-release/blob/master/check_staged_re >>> lease.sh >>> >>> Usage: >>> sh check_staged_release.sh 1832 /tmp/sling-staging >>> >>> Please vote to approve this release: >>> >>> [ ] +1 Approve the release >>> [ ] 0 Don't care >>> [ ] -1 Don't release, because ... >>> >>> This majority vote is open for at least 72 hours. >> >> -1 provisioning model contains snapshot, build is therefore not reproducible > > Right > (https://github.com/apache/sling-org-apache-sling-validation-core/blob/org.apache.sling.validation.core-1.0.2/src/test/provisioning/model.txt#L24 > > <https://github.com/apache/sling-org-apache-sling-validation-core/blob/org.apache.sling.validation.core-1.0.2/src/test/provisioning/model.txt#L24>). > The issue is that the maven-release-plugin does not automatically adjust the > versions in there. But the provisioning model is only used to run the IT > against it. It should not actually be deployed (but is due to > https://issues.apache.org/jira/browse/SLING-7299 > <https://issues.apache.org/jira/browse/SLING-7299>). I will try to come up > with a fix for that in slingstart-maven-plugin (maybe leveraging/extending > http://sling.apache.org/components/slingstart-maven-plugin/prepare-package-mojo.html#usePomDependencies > > <http://sling.apache.org/components/slingstart-maven-plugin/prepare-package-mojo.html#usePomDependencies> > would be an option). >> >> Regards, >> O. >> >>> Thanks, >>> Konrad >
