[ 
https://issues.apache.org/jira/browse/SLING-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300274#comment-16300274
 ] 

Justin Edelson commented on SLING-7321:
---------------------------------------

I have a few stylistic comments to make in GitHub, but generally I agree that 
this looks like a fine addition. Thanks!

> ChildResourceViaProvider should be able to deal with SlingHttpServletRequest
> ----------------------------------------------------------------------------
>
>                 Key: SLING-7321
>                 URL: https://issues.apache.org/jira/browse/SLING-7321
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.4.6
>            Reporter: Santiago GarcĂ­a Pimentel
>            Priority: Minor
>             Fix For: Sling Models Impl 1.4.8
>
>
> The ForcedResourceType and ResourceSuperType are able to deal with Sling 
> requests by creating a wrapper request that returns a wrapped Request.
> Still, the ChildResourceViaProvider does not offer such possibility. I think 
> that for sake of consistency it should.
> I propose that if the adaptable is a SlingHttpServletRequest the 
> ChildResourceViaProvider  should create a request wrapper that returns the 
> child as given in 'value'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to