[ 
https://issues.apache.org/jira/browse/SLING-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326973#comment-16326973
 ] 

ASF GitHub Bot commented on SLING-7364:
---------------------------------------

Buuhuu opened a new pull request #6: SLING-7364: optionally omit package 
metadata header
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/6
 
 
   This change includes a configuration about including the package metadata 
header in the packages binary stream or not (defaults to true, to be downwards 
compatible). It only applies for the DistributionPackageBuilderFactory **not** 
for the vlt one, as I assume vlt most likely makes only sense when integrating 
sling-sling.
   
   I also moved all the constants used for DistributionPackage.getInfo() as 
final static fields to the DistributionPackageInfo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Transport DistributionPackageInfo as Http headers
> -------------------------------------------------
>
>                 Key: SLING-7364
>                 URL: https://issues.apache.org/jira/browse/SLING-7364
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>    Affects Versions: Content Distribution Core 0.2.10
>            Reporter: Dirk Rudolph
>            Priority: Minor
>
> Currently DistributionPackages are sent over wire including there info as 
> headers in the binary stream. In SLING-7357 I proposed that its the 
> responsibility of the serializer to specify which kind of content it is 
> serializing. Unfortunately as SimpleHttpDistributionTransport prepends the 
> DistributionPackageInfo the content is not of the content type serialized 
> anymore and the consumer side has to first read the package info before the 
> actual content can be read.
> For example in my demo to integrate SCD with solr I had to write a custom 
> UpdateRequestHandler to be able to parse the json I'm sending to solr with 
> SCD:
> https://github.com/Buuhuu/sling-content-distribution-solr/blob/master/sling-content-distribution-solr-loader/src/main/java/com/github/buuhuu/solr/handler/SCDUpdateRequestHandler.java
> If possible it would be nice to have those info transmitted using http 
> headers, which would allow to integrate into other systems as they are.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to