[
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346330#comment-16346330
]
ASF GitHub Bot commented on SLING-7454:
---------------------------------------
kwin commented on a change in pull request #3: SLING-7454: Make the IT use the
latest repoinit snapshots, enable dis…
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164962867
##########
File path: pom.xml
##########
@@ -110,35 +110,40 @@
<!-- the Sling instance is provisioned from the model in
src/main/provisioning/model.txt -->
<groupId>org.apache.sling</groupId>
<artifactId>slingstart-maven-plugin</artifactId>
- <version>1.7.0</version>
+ <version>1.7.16</version>
<extensions>true</extensions>
<executions>
<execution>
<id>prepare-launchpad-package</id>
+ <phase>pre-integration-test</phase>
<goals>
<goal>prepare-package</goal>
</goals>
</execution>
<execution>
<id>build-launchpad-package</id>
+ <phase>pre-integration-test</phase>
<goals>
<goal>package</goal>
</goals>
Review comment:
You should configure attachArtifact to false to prevent the IT launchpad
from being deployed with the release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move repoinit integration tests to the JCR repoinit module
> ----------------------------------------------------------
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
> Issue Type: Task
> Components: Repoinit
> Affects Versions: Repoinit JCR 1.1.6
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has
> similar dependencies, and in that way they are executed at the right time,
> before releasing that module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
