rombert commented on a change in pull request #1: SLING-7423 Migrate to Oak 1.8 URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#discussion_r167486967
########## File path: pom.xml ########## @@ -208,6 +208,13 @@ <artifactId>slf4j-api</artifactId> <scope>provided</scope> </dependency> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-jdk14</artifactId> Review comment: Does `slf4j-simple` work here as well? I don't strongly prefer either dependency, but since we use `slf4j-simple` in most other places it would be more consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services