[
https://issues.apache.org/jira/browse/SLING-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407944#comment-16407944
]
ASF GitHub Bot commented on SLING-7544:
---------------------------------------
rombert commented on a change in pull request #5: SLING-7544 - improving
optimized alias lookup to not block during int…
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r176089556
##########
File path:
src/test/java/org/apache/sling/resourceresolver/impl/mapping/MapEntriesTest.java
##########
@@ -168,6 +172,8 @@ public void test_simple_alias_support() {
});
mapEntries.doInit();
+
+ while(!mapEntries.isAliasMapInitialized()){}
Review comment:
An empty loop looks wrong. I know what it does :-) but it looks wrong. I
would suggest either adding a method to mapEntries for waiting for it to be
available or using a test helper method.
Also please add timeouts to all methods having such async logic to prevent
them from hanging indefinitely under special circumstances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make optimized alias lookup non-blocking
> ----------------------------------------
>
> Key: SLING-7544
> URL: https://issues.apache.org/jira/browse/SLING-7544
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.5.36
> Reporter: Dominik Süß
> Priority: Major
>
> The implementation of optimized alias lookup as introduced with SLING-2521
> blocks CommonResourceResolver activation while loading aliases to fillup the
> aliasmap. In case a corresponding index is not present yet this can lead to
> full tree traversal while indexing is doing the same in the background.
> The proposed improvements are:
> * making loading of the aliasmap happen asynchronously
> * only use optimized handling as soon as aliasmap is built
> * wait for non traversal index (optional - forced by default, can be turned
> off for small datasets)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
