[
https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448072#comment-16448072
]
Bertrand Delacretaz edited comment on SLING-7612 at 4/23/18 12:43 PM:
----------------------------------------------------------------------
Does this bring any actual benefit besides being "more modern", in a way?
I'm a bit wary as using DS will slightly change the startup dynamics, i.e. with
this the TikaMimeTypeProvider will start later and other components might see
the mime type service without that feature being active (_comment edited, I
misunderstood initially_).
If the changes does bring any actual benefits why not, but I'm not sure that's
the case - might be worth a discussion on our dev list.
was (Author: bdelacretaz):
Does this bring any actual benefit besides being "more modern", in a way?
I'm a bit wary as using DS will slightly change the startup dynamics and I
suppose many components have a reference to the MimeTypeService and as such
might start later, as MimeTypeService will now wait for DS.
If the changes does bring any actual benefits why not, but I'm not sure that's
the case - might be worth a discussion on our dev list.
> Use Declarative Services to register optional components
> --------------------------------------------------------
>
> Key: SLING-7612
> URL: https://issues.apache.org/jira/browse/SLING-7612
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Affects Versions: Commons Mime 2.1.10
> Reporter: Christian Schneider
> Priority: Major
> Fix For: Commons Mime 2.1.12
>
>
> Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin
> are registered programmatically. I guess this is done make sure they work
> with the optional package dependencies.
> I recently learned that DS is very good to handle this case. So I propose to
> do both with simple DS component annotations. I will provide a PR.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
