[ https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448182#comment-16448182 ]
Bertrand Delacretaz commented on SLING-7612: -------------------------------------------- hehe, this old stuff challenges our memories of how things were built ;-) We might accept these changes then but if we do so I suggest adding a backwards compatibility note in the README, about potential startup sequence changes. Nothing that this shouldn't be a problem if Declarative Services are available before this module starts. > Use Declarative Services to register optional components > -------------------------------------------------------- > > Key: SLING-7612 > URL: https://issues.apache.org/jira/browse/SLING-7612 > Project: Sling > Issue Type: Improvement > Components: Commons > Affects Versions: Commons Mime 2.1.10 > Reporter: Christian Schneider > Priority: Major > Fix For: Commons Mime 2.1.12 > > > Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin > are registered programmatically. I guess this is done make sure they work > with the optional package dependencies. > I recently learned that DS is very good to handle this case. So I propose to > do both with simple DS component annotations. I will provide a PR. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)