[ https://issues.apache.org/jira/browse/SLING-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463766#comment-16463766 ]
Dominik Süß commented on SLING-7544: ------------------------------------ [~rombert] there was a potential race when new aliases get added while the intialization was still running. The tests failed slightly differently because of the way the mocking is done (directly accessing some of the private methods) but the PR addresses this as well - also added a corresponding test to validate that the update is queued up and just visible in the aliasmap after initialization completes. > Make optimized alias lookup non-blocking > ---------------------------------------- > > Key: SLING-7544 > URL: https://issues.apache.org/jira/browse/SLING-7544 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver > Affects Versions: Resource Resolver 1.5.36 > Reporter: Dominik Süß > Assignee: Robert Munteanu > Priority: Major > Fix For: Resource Resolver 1.6.2 > > Time Spent: 2.5h > Remaining Estimate: 0h > > The implementation of optimized alias lookup as introduced with SLING-2521 > blocks CommonResourceResolver activation while loading aliases to fillup the > aliasmap. In case a corresponding index is not present yet this can lead to > full tree traversal while indexing is doing the same in the background. > The proposed improvements are: > * making loading of the aliasmap happen asynchronously > * only use optimized handling as soon as aliasmap is built > * wait for non traversal index (optional - forced by default, can be turned > off for small datasets) -- This message was sent by Atlassian JIRA (v7.6.3#76005)