[
https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473560#comment-16473560
]
Konrad Windszus edited comment on SLING-7624 at 5/13/18 5:00 PM:
-----------------------------------------------------------------
Having single value annotations mainly means, that the generated descriptor is
not compatible with DS 1.3 (compare with
https://github.com/bndtools/bnd/issues/2163#issuecomment-385034654).
For the servlet name I did the split already.
[~cziegeler] What is the reason why you think that SlingServletByResourceType
should be a single value annotation? I think all those aspect should be
maintained in the same annotation, because those only make sense in the
combination with a servlet registered as resource type (you cannot restrict
either methods, selectors or extension for path-bound servlets!)
Do you have any idea why the prefixed servlets do not work in the IT
(https://github.com/kwin/sling-org-apache-sling-servlets-annotations-it/blob/437200a3feb69613a7de5063ccbc4022bfd7dcb7/src/test/java/org/apache/sling/servlets/annotations/ServletRegistrationIT.java#L86)?
was (Author: kwin):
Having single value annotations mainly means, that the generated descriptor is
not compatible with DS 1.3 (compare with
https://github.com/bndtools/bnd/issues/2163#issuecomment-385034654).
For the servlet name I did the split already.
What is the reason why you think that SlingServletByResourceType should be a
single value annotation? I think all those aspect should be maintained in the
same annotation, because those only make sense in the combination with a
servlet registered as resource type (you cannot restrict either methods,
selectors or extension for path-bound servlets!)
> Add OSGi7 component property annotations for Servlet and Filter
> ---------------------------------------------------------------
>
> Key: SLING-7624
> URL: https://issues.apache.org/jira/browse/SLING-7624
> Project: Sling
> Issue Type: New Feature
> Components: Servlets
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Previously there were annotations hosted at Felix for Sling Servlets/Filters
> as custom Felix SCR annotations
> (https://github.com/apache/felix/tree/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling).
> With OSGi R7 and DS 1.4 component property annotations are specified. Sling
> should provide those annotations in a dedicated new artifact. Compare also
> with FELIX-5396.
> Those are supported in the upcoming bnd 4.0
> (https://github.com/bndtools/bnd/issues/2163).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
