hasinidilanka commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190706351
########## File path: oidc-handler/pom.xml ########## @@ -1,11 +1,35 @@ <?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <groupId>org.apache.sling</groupId> + <artifactId>org.apache.sling.oidchandler</artifactId> + <version>1.0.0-SNAPSHOT</version> + <packaging>pom</packaging> + <name>org.apache.sling.oidchandler</name> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <properties> + <sling.username>admin</sling.username> + <sling.password>admin</sling.password> + </properties> - <modelVersion>4.0.0</modelVersion> - <groupId>org.apache.sling</groupId> - <artifactId>org.apache.sling.oidchandler</artifactId> - <version>1.0-SNAPSHOT</version> + <build> Review comment: If this plugin is removed, the project cannot be implemented using mvn package sling:install. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
