rombert closed pull request #4: Provide name hints for SDI configuration entries
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
b/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
index f3b80a9..9cb6695 100755
--- a/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
+++ b/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
@@ -60,7 +60,8 @@
@Property(name = Configuration.PROPERTY_COMPONENT_TTL, label = "Component
TTL", description = "\"Time to live\" cache header for rendered component (in
seconds)"),
@Property(name = Configuration.PROPERTY_REQUIRED_HEADER, value =
Configuration.DEFAULT_REQUIRED_HEADER, label = "Required header", description =
"SDI will work only for requests with given header"),
@Property(name = Configuration.PROPERTY_IGNORE_URL_PARAMS, cardinality =
Integer.MAX_VALUE, label = "Ignore URL params", description = "SDI will process
the request even if it contains configured GET parameters"),
- @Property(name = Configuration.PROPERTY_REWRITE_PATH, boolValue =
Configuration.DEFAULT_REWRITE_DISABLED, label = "Include path rewriting",
description = "Check to enable include path rewriting")})
+ @Property(name = Configuration.PROPERTY_REWRITE_PATH, boolValue =
Configuration.DEFAULT_REWRITE_DISABLED, label = "Include path rewriting",
description = "Check to enable include path rewriting"),
+ @Property(name= Configuration.NAME_HINT_PROPERTY_NAME,
value=Configuration.NAME_HINT_VALUE)})
public class Configuration {
private static final Logger LOG =
LoggerFactory.getLogger(Configuration.class);
@@ -97,6 +98,11 @@
static final String PROPERTY_REWRITE_PATH = "include-filter.config.rewrite";
+ static final String NAME_HINT_PROPERTY_NAME =
"webconsole.configurationFactory.nameHint";
+
+ static final String NAME_HINT_VALUE = "{" + PROPERTY_INCLUDE_TYPE + "} for
[{"
+ + PROPERTY_FILTER_RESOURCE_TYPES + "}] at path: {" +
PROPERTY_FILTER_PATH + "}";
+
static final boolean DEFAULT_REWRITE_DISABLED = false;
private PathMatcher pathMatcher;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
