[ 
https://issues.apache.org/jira/browse/SLING-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520430#comment-16520430
 ] 

ASF GitHub Bot commented on SLING-7752:
---------------------------------------

andreituicu commented on issue #2: SLING-7752 - Deserializing and serializing a 
feature model file suffles the configurations
URL: 
https://github.com/apache/sling-org-apache-sling-feature/pull/2#issuecomment-399464644
 
 
   @rombert @bosschaert Thank you for the review! I updated the PR according to 
your review. I changed the API to use `Map` and `LinkedHashMap` and updated the 
necessary code. One thing to note is that now the baseline plugin fails the 
build as it wants a version bump to `1.0.0` and this would take us out of the 
beta and into the backwards compatibility zone. Is there anything I can do to 
make it stop or will it have to be skipped at the release time? I'll see if 
this change has any implications on 
https://github.com/apache/sling-org-apache-sling-feature-io.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Deserializing and serializing a feature model file suffles the configurations
> -----------------------------------------------------------------------------
>
>                 Key: SLING-7752
>                 URL: https://issues.apache.org/jira/browse/SLING-7752
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>            Reporter: Andrei Tuicu
>            Priority: Major
>
> h3. Problem
> Deserializing and serializing a feature model file suffles the 
> configurations. This happens, because unordered maps (HashMaps/Hashtables) 
> are used in the implementations. The problem is relevant in the context of 
> adding these files in code versioning systems, because a minor change to a 
> file, done in an automated fashion, produces a big diff in the versioning 
> system and it becomes very hard to see exactly what is the relevant change. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to