[
https://issues.apache.org/jira/browse/SLING-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527452#comment-16527452
]
Konrad Windszus edited comment on SLING-7736 at 6/29/18 10:53 AM:
------------------------------------------------------------------
The {{ConfigTaskCreator}} already implements a configuration listener and
notifies the OSGi Installer about the change
(https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/0df065077af77f07955f9420158b008d73ce5ed3/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigTaskCreator.java#L99).
But this is not correctly propagated then and does not lead to a resource
status "IGNORED" yet (in case write back is not enabled)
Also for bundle events there is no such listener yet, which propagates changes
to the OSGi Installer.
was (Author: kwin):
The {{ConfigTaskCreator}} already implements a configuration listener and
notifies the OSGi Installer about the change
(https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/0df065077af77f07955f9420158b008d73ce5ed3/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigTaskCreator.java#L99).
But this is not correctly propagated then and does not lead to a resource
status "IGNORED" yet.
Also for bundle events there is no such listener yet, which propagates changes
to the OSGi Installer.
> OSGi Installer: Update OSGi installer's resource state in case of
> configuration/bundle updates outside of the OSGi Installer
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-7736
> URL: https://issues.apache.org/jira/browse/SLING-7736
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.8.10, Installer Configuration Factory
> 1.2.0
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently the state of an OSGi installer's resource is only updated whenever
> it is newly added to the queue and subsequently processed. Manual
> configuration/bundle changes outside of the OSGi installer don't change the
> OSGi installer's resource state.
> Actually, with the help of the {{BundleListener}}
> (https://osgi.org/javadoc/r5/core/org/osgi/framework/BundleListener.html) and
> the {{ConfigurationListener}}
> (https://osgi.org/javadoc/r5/cmpn/org/osgi/service/cm/ConfigurationListener.html)
> the OSGi installer could mark the according OSGi installer resources as
> {{IGNORED}} in case they have been overwritten.
> The tricky part is to filter out those event's which have been caused by the
> OSGi installer itself. The resource's digest cannot be used for that, as that
> is completely calculated by the Provider (i.e. is different between JCR and
> file provider).
> That would improve the effectiveness of the health check from SLING-5888 and
> also allows the OSGi installer to better enforce its state during
> reinstallation in the future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
