[ https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530899#comment-16530899 ]
indra kumar gurjar commented on SLING-7756: ------------------------------------------- [~kwin] I think the logging is already there with DEBUG log level at [0], and [1] but it doesn't contain retry count info. Can we improve this logging by adding retry info? Is the log level DEBUG enough here or we should change it to WARN/ERROR ? I will open a PR with changes after your thoughts on above points. Thanks! [0]:[https://github.com/apache/sling-org-apache-sling-event/blob/ca009499cbe30ae30df5069effe051e0bef9ef72/src/main/java/org/apache/sling/event/impl/jobs/queues/JobQueueImpl.java#L465] [1]:https://github.com/apache/sling-org-apache-sling-event/blob/ca009499cbe30ae30df5069effe051e0bef9ef72/src/main/java/org/apache/sling/event/impl/jobs/queues/JobQueueImpl.java#L458 > Improve logging for Job retries > ------------------------------- > > Key: SLING-7756 > URL: https://issues.apache.org/jira/browse/SLING-7756 > Project: Sling > Issue Type: Improvement > Components: Event > Affects Versions: Event 4.2.10 > Reporter: Konrad Windszus > Priority: Major > > Currently a {{JobConsumer}} returning {{JobResult.FAILED}} is usually retried > (https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html). > Unfortunately this is not exposed in the logs, so in case a JobConsumer logs > an error before returning {{JobResult.FAILED}} the job is silently retried > without any particular log message. I think each failed job should lead to a > WARN in the log (in case the job is retried) with the attempt number and > outstanding attempts in the log message. In case a job is not retried, an > ERROR should be emitted to the log for every failed job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)