[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533501#comment-16533501
]
Nicolas Peltier edited comment on SLING-7759 at 7/5/18 10:47 AM:
-----------------------------------------------------------------
ok [~jsedding]
{quote}Handling between path and suffix matching is slightly different, as path
is set to "/" if it is
blank. Is this desired or accidental?{quote}
i'm reproducing (and covering with a unit test) behaviour before this change,
pls check initial code
{quote}Do you mean the null checks? If that's the case, I wouldn't worry.{quote}
yeah that's what i mean, again, i was lost in my lambda thinking, i find your
code much clearer, simpler, and yeah performance wise, i think that should be
completely fine.
merged your PR, added a few minor changes + dpe removal here
https://github.com/apache/sling-org-apache-sling-engine/pull/3/commits/b00e55e9dd13c57f00262553c87f211f2d6afb5f
as mentionned in the PR i think we should squash this. Please review and i'll
go ahead (if one reviewer is fine)
was (Author: npeltier):
ok [~jsedding] merged your PR, added a few minor changes + dpe removal here
https://github.com/apache/sling-org-apache-sling-engine/pull/3/commits/b00e55e9dd13c57f00262553c87f211f2d6afb5f
as mentionned in the PR i think we should squash this. Please review and i'll
go ahead (if one reviewer is fine)
> add other "patterns" than path for filters
> ------------------------------------------
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Engine 2.6.12
> Reporter: Nicolas Peltier
> Assignee: Nicolas Peltier
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
