[ https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541506#comment-16541506 ]
ASF GitHub Bot commented on SLING-7759: --------------------------------------- kwin commented on issue #1: SLING-7759 add new patterns to filter annotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/1#issuecomment-404484048 Looks good to me now, thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add other "patterns" than path for filters > ------------------------------------------ > > Key: SLING-7759 > URL: https://issues.apache.org/jira/browse/SLING-7759 > Project: Sling > Issue Type: Improvement > Components: Engine > Affects Versions: Engine 2.6.12, Sling Servlet Annotations 1.0.0 > Reporter: Nicolas Peltier > Assignee: Nicolas Peltier > Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > adding additional patterns to filters (right now {{sling.filter.pattern}} > allows to include them based on path only): > - path passes if sling.filter.pattern (i propose we keep it for legacy & add > sling.filter.pattern.path for consistency with what follow) regexp matches > current path, > - selector passes if sling.filter.pattern.selector is in the selector chain, > - method passes if sling.filter.pattern.method is equals to curren method, > - suffix passes if sling.filter.pattern.suffix regep matches current suffix -- This message was sent by Atlassian JIRA (v7.6.3#76005)