rombert commented on issue #6: Allow caching of virtual resources URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-409552732 I get compilation errors when building this module with your patch on top. ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project org.apache.sling.dynamic-include: Compilation failure: Compilation failure: [ERROR] /home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[45,41] method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder cannot be applied to given types; [ERROR] required: java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo [ERROR] found: java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[56,41] method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder cannot be applied to given types; [ERROR] required: java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo [ERROR] found: java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[67,41] method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder cannot be applied to given types; [ERROR] required: java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo [ERROR] found: java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[78,41] method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder cannot be applied to given types; [ERROR] required: java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo [ERROR] found: java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[89,41] method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder cannot be applied to given types; [ERROR] required: java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo [ERROR] found: java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /home/robert/Documents/sources/apache/sling/org-apache-sling-dynamic-include/src/test/java/org/apache/sling/dynamicinclude/impl/UrlBuilderTest.java:[100,41] method buildUrl in class org.apache.sling.dynamicinclude.impl.UrlBuilder cannot be applied to given types; [ERROR] required: java.lang.String,java.lang.String,boolean,org.apache.sling.dynamicinclude.Configuration,org.apache.sling.api.request.RequestPathInfo [ERROR] found: java.lang.String,java.lang.String,boolean,org.apache.sling.api.request.RequestPathInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException ``` I'm using ``` $ mvn -v Maven home: /usr/share/java/maven Java version: 1.8.0_171, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.17.9-1-default", arch: "amd64", family: "unix" ``` Does this happen at your end as well?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services