npeltier commented on a change in pull request #5: SLING-7707 Create Executor 
Pipe
URL: 
https://github.com/apache/sling-org-apache-sling-pipes/pull/5#discussion_r215869613
 
 

 ##########
 File path: src/main/java/org/apache/sling/pipes/internal/PipeBuilderImpl.java
 ##########
 @@ -376,6 +377,17 @@ public Job runAsync(Map bindings) throws 
PersistenceException {
         return plumber.executeAsync(resolver, pipe.getResource().getPath(), 
bindings);
     }
 
+    @Override
+    public ExecutionResult runParallel(int numThreads) throws Exception {
+        JsonWriter writer = new JsonWriter();
+        writer.starts();
+        Pipe pipe = this.build();
 
 Review comment:
   this looks strange, i wonder if we shouldn't make that call just change the 
main pipe from container to "threadedpipe"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to