[
https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641949#comment-16641949
]
ASF GitHub Bot commented on SLING-7988:
---------------------------------------
bosschaert commented on a change in pull request #5: SLING-7988 - Allow
Analyzer include/exclude tasks by id, in order to enable specific Tasks in the
Maven plugin
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#discussion_r223394780
##########
File path:
src/main/java/org/apache/sling/feature/analyser/task/AnalyzerTaskProvider.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.feature.analyser.task;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.sling.feature.analyser.Analyser;
+
+public final class AnalyzerTaskProvider {
Review comment:
Does this new class need to be public? If it's only used from within the
same package then 'package' protected should also be possible, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks
> in the Maven plugin
> -------------------------------------------------------------------------------------------------
>
> Key: SLING-7988
> URL: https://issues.apache.org/jira/browse/SLING-7988
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Major
>
> Current Maven Feature Plugin Analyze MOJO executes all tasks in the
> classpath, it should be possible to select them via the typical
> include/exclude plugin configuration pattern.
> A first initial modification is needed in the Analyzer component, I am going
> to submit a PR about it - once applied, the Maven plugin can be modified in
> order to select tasks to perform during the analysis
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
