DominikSuess commented on a change in pull request #14: Issue/sling 8038
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r228343399
 
 

 ##########
 File path: 
src/main/java/org/apache/sling/feature/maven/mojos/AbstractRepositoryMojo.java
 ##########
 @@ -65,7 +65,12 @@
 
     @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
-        final File artifactDir = new 
File(this.project.getBuild().getDirectory(), repositoryDir);
+        final File artifactDir ;
 
 Review comment:
   @simonetripodi  the intention was to get rid of a project dir and make this 
independent of a project - following patterns of other maven plugins I detect 
the unreplaced project build dir to handle this case. If triggered in a non 
project folder the target folder can be defined relative to execution dir or 
absolute.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to