cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436665548 The patch looks good to me, the only minor thing is that we should think about prefixing the parameters with something task related, otherwise we might run into a clash between two tasks using the same parameter name. Obviously as XML is used in maven we can't use a colon, so maybe an underscore and keys will become taskname_parametername. The analyser would get such keys, and when it invokes a task it will only pass in the parameters with the right prefix or parameters not having a prefix and removes the prefix. For example if these parameters are passed into the Analyser mytask_foo=one mytask_hi=hello nexttask_bla=two debug=true and the analyser invokes the task named "mytask", the following paramters are available through the context foo=one hi=hello debug=true
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
