cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959908
##########
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##########
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+ checkFeatureFileValidation(file);
+
Review comment:
If you validate the file, the validation might fail as the "id" property
might not be set, this will be set by calling the next method, so validation
should happen within that method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
